FINERACT-2643: Refactor NewCommandSourceHandler implementation classes to use @RequiredArgsConstructor Lombok#6006
Open
atharva-kamat wants to merge 1 commit into
Conversation
Member
|
@atharva-kamat Your PR touches lot of files maybe you can split this into small PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor command handlers to use Lombok @requiredargsconstructor for constructor injection
While the majority of our newer components and services across the codebase correctly leverage Lombok's @requiredargsconstructor to handle clean constructor-based dependency injection, several older command handler classes (such as UpdateReportCommandHandler, {}UpdateJobDetailCommandhandler{}) present in fineract-provider are still using explicit manual constructors combined with redundant @Autowired annotations.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.